Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Factor out core AT-SPI translation layer #352

Merged
merged 31 commits into from
Feb 24, 2024
Merged

feat: Factor out core AT-SPI translation layer #352

merged 31 commits into from
Feb 24, 2024

Commits on Feb 21, 2024

  1. fix: Factor out core translation layer between AccessKit and AT-SPI

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9e1a457 View commit details
    Browse the repository at this point in the history

  2. Refactor unregister_interfaces

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5667a84 View commit details
    Browse the repository at this point in the history

  3. Refactor register_interfaces

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    fd6e602 View commit details
    Browse the repository at this point in the history

  4. Prepare for event refactoring; eliminate most PlatformNode constructi… 

    …on for tree traversal
    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e475b29 View commit details
    Browse the repository at this point in the history

  5. Do the event refactor

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7a0846b View commit details
    Browse the repository at this point in the history

  6. Eliminate churn in get_child_at_index and get_children on root

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    bf52f1b View commit details
    Browse the repository at this point in the history

  7. Just one adapter ID

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1c16e77 View commit details
    Browse the repository at this point in the history

  8. AdapterIdToken, not AdapterIdGuard

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f79343a View commit details
    Browse the repository at this point in the history

  9. Refactor the callback

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    35e590f View commit details
    Browse the repository at this point in the history

  10. move adapter ID out of context; pull out a helper function for creati… 

    …ng platform nodes for the root's children
    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f30a58e View commit details
    Browse the repository at this point in the history

  11. Eliminate intermediate Vecs

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    6e663a4 View commit details
    Browse the repository at this point in the history

  12. Always use a stored bus address rather than looking at the message he… 

    …ader
    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3593564 View commit details
    Browse the repository at this point in the history

  13. fix one clippy warning

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    29d3146 View commit details
    Browse the repository at this point in the history

  14. fix more clippy warnings

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    ca8527f View commit details
    Browse the repository at this point in the history

  15. Drop get_ prefix on some PlatformNode methods, for consistency, n… 

    …ow that this interface is public
    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    66e6d6f View commit details
    Browse the repository at this point in the history

  16. derive Debug on events

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    77a6d69 View commit details
    Browse the repository at this point in the history

  17. Add a way for an event handler to create a PlatformRoot

    @mwcampbell
    mwcampbell committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c33fb71 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. make the fields of Rect public, since they need to be accessed direct… 

    …ly by the Newton AT-SPI compat library
    @mwcampbell
    mwcampbell committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b8fe547 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. In PlatformNode::state, translate errors to State::Defunct

    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    62d89d6 View commit details
    Browse the repository at this point in the history

  2. Add PlatformNode methods to check support for single interfaces

    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6457f62 View commit details
    Browse the repository at this point in the history

  3. Add a way to get to the root from a PlatformNode

    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    92690cd View commit details
    Browse the repository at this point in the history

  4. Add a new UnsupportedInterface error; I was previously abusing `Def… 

    …unct` for that. Both still translate to "unknown object" in D-Bus.
    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ead59e5 View commit details
    Browse the repository at this point in the history

  5. Add direct toolkit_name and toolkit_version methods to PlatformNode

    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    fa2ba93 View commit details
    Browse the repository at this point in the history

  6. Implement PartialEq, Eq, and Hash for PlatformNode

    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1bedc27 View commit details
    Browse the repository at this point in the history

  7. Implement PartialEq and Hash for PlatformRoot. Not sure about Eq when… 

    … doing pointer comparison on weak references.
    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4d784ba View commit details
    Browse the repository at this point in the history

  8. Derive PartialEq and Eq on Rect

    @mwcampbell
    mwcampbell committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8d64af6 View commit details
    Browse the repository at this point in the history

  9. Consistently use supports_value 

    Co-authored-by: Arnold Loubriat <datatriny@gmail.com>
    @mwcampbell @DataTriny
    mwcampbell and DataTriny committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    eb4ac6e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Add the simplified, libatspi-like API that I implemented for the newt… 

    …on_atspi_compat Python package
    @mwcampbell
    mwcampbell committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    12053df View commit details
    Browse the repository at this point in the history

  2. forgot a reexport

    @mwcampbell
    mwcampbell committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    ab8e8d0 View commit details
    Browse the repository at this point in the history

  3. Add the action and component interfaces (the subsets that we already … 

    …implement) to the simplified API
    @mwcampbell
    mwcampbell committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    b75f6c1 View commit details
    Browse the repository at this point in the history

  4. Back out changes to accesskit_unix; will open a second PR for that

    @mwcampbell
    mwcampbell committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    1909440 View commit details
    Browse the repository at this point in the history