Skip to content

Commit

Permalink
Merge pull request #482 from AcclaroInc/release/3.3.2
Browse files Browse the repository at this point in the history
Release/3.3.2
  • Loading branch information
bhupeshappfoster committed Nov 6, 2023
2 parents d9bae00 + 1c09d21 commit 75ba59b
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .craftplugin
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"pluginName": "Translations for Craft",
"pluginDescription": "Drive global growth with simplified translation workflows.",
"pluginVersion": "3.3.1",
"pluginVersion": "3.3.2",
"pluginAuthorName": "Acclaro",
"pluginVendorName": "Acclaro",
"pluginAuthorUrl": "http://www.acclaro.com/",
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).

## 3.3.2 - 2023-11-06

### Fixed
- An issue where order comments were not sent to acclaro.([AcclaroInc#482](https://github.com/AcclaroInc/craft-translations/pull/482))


## 3.3.1 - 2023-10-05

### Added
Expand Down
4 changes: 4 additions & 0 deletions src/services/repository/OrderRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,10 @@ public function sendAcclaroOrder($order, $settings, $queue=null) {
$translationService->addOrderTags($orderResponse->orderid, implode(",", $tags));
}
}

if ($comments) {
$translationService->addOrderComments($orderResponse->orderid, $comments);
}

$orderReferenceFiles = [];

Expand Down
5 changes: 5 additions & 0 deletions src/services/translator/AcclaroTranslationService.php
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,11 @@ public function addOrderTags($orderId, $tags)
{
return $this->apiClient->addOrderTags($orderId, $tags);
}

public function addOrderComments($orderId, $comment)
{
return $this->apiClient->addOrderComment($orderId, $comment);
}

public function getOrderQuote($orderId)
{
Expand Down

0 comments on commit 75ba59b

Please sign in to comment.