Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updt: updated how generic translator proccess redactor fields #364

Merged
merged 1 commit into from Jul 26, 2022

Conversation

bhupeshappfoster
Copy link
Collaborator

Fixed

  • An issue where redactor fields links missing their extra details in exported xml file. (AcclaroInc#491)

Note

This change however provides the missing data in exported xml file but links are still pointing to source site after translation.
Opened an issue in redactor repository for same here

@bhupeshappfoster bhupeshappfoster added the type: bug Something isn't working label Jul 20, 2022
@bhupeshappfoster bhupeshappfoster self-assigned this Jul 20, 2022
@blafferty
Copy link
Collaborator

@bhupeshappfoster - Just to confirm, this update will fix this issue reported in https://github.com/AcclaroInc/pm-craft-translations/issues/491?

@bhupeshappfoster
Copy link
Collaborator Author

@blafferty @sidedwards

@bhupeshappfoster - Just to confirm, this update will fix this issue reported in AcclaroInc/pm-craft-translations#491?

We made the required changes to fix this issue in our side, where url was missing some part of it in translations file.

image

Still the url after translations point to source site, have opened an issue with redactor for same here

@sidedwards sidedwards merged commit d30f955 into release/2.2.3 Jul 26, 2022
@bhupeshappfoster bhupeshappfoster mentioned this pull request Jul 26, 2022
@bhupeshappfoster bhupeshappfoster deleted the fix/redactor-url-propagation-issue branch July 27, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants