Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Error Handling #355

Merged
merged 11 commits into from
Sep 12, 2023

Conversation

aljcalandra
Copy link
Contributor

  • Added an error class
  • Made validation logic clearer in one case

@coveralls
Copy link

coveralls commented Jul 25, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 31745ea on aljcalandra:alternative_error_handling into 756730a on Accruent:master.

@aljcalandra
Copy link
Contributor Author

Is there anything that can be done for the failing tests or is this issue caused elsewhere?

@Wolfe1
Copy link
Member

Wolfe1 commented Jul 31, 2023

  1. Thanks for the pull request long time no see ♥
  2. That Edge test is just flakiness, not sure about the "generate_report" job either just thats just broken it looks like.
  3. The chrome tests are actual "failures" caused by the code change (They passed today for a dependabot update from Robotframework). Since the error messages changed in your pull request, the expected values for those tests need to be modified to match.

@aljcalandra
Copy link
Contributor Author

aljcalandra commented Sep 11, 2023

Oof just saw the response, I'll go through and fix that up when I get a chance

Oh also, fun stuff, w3schools has different css for edge vs chrome.

@aljcalandra
Copy link
Contributor Author

The token used for the generate_report job does not have write permissions for issues/pullrequests so I think it'll fail until that gets updated.
Alternatively it might be worth looking into the replacing it with the summary action.

@Wolfe1 Wolfe1 merged commit d0fafa2 into Accruent:master Sep 12, 2023
25 of 26 checks passed
@Wolfe1
Copy link
Member

Wolfe1 commented Sep 12, 2023

Appreciate the effort, thanks!

@aljcalandra aljcalandra deleted the alternative_error_handling branch September 12, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants