Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft. Bug fixes on daemon, build probs and slowness #76

Merged
merged 9 commits into from
Mar 23, 2022

Conversation

willwade
Copy link
Contributor

No description provided.

@willwade willwade changed the title Draft. Bug fixes on date Draft. Bug fixes on daemon, build probs and slowness Mar 15, 2022
@willwade
Copy link
Contributor Author

willwade commented Mar 15, 2022

For #72 #71 #75 #63

@willwade
Copy link
Contributor Author

@joedevsys feel free to try this if you get a chance.

@willwade
Copy link
Contributor Author

willwade commented Mar 21, 2022

Download of compiled binary and installer here: https://acecentreuk.sharepoint.com/:u:/s/AnonymousShares/EQOWTu5bMbNJn5R91_jos-8BZhGAN8ItWXA-_rsDGsmxdw?e=xna6hq

@f1andrew working on

  • Deleting devices - singly or all
  • Any tweaks for improvement anywhere else!

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 22, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.28%.

Quality metrics Before After Change
Complexity 19.71 😞 19.66 😞 -0.05 👍
Method Length 90.07 🙂 89.10 🙂 -0.97 👍
Working memory 10.20 😞 10.16 😞 -0.04 👍
Quality 51.38% 🙂 51.66% 🙂 0.28% 👍
Other metrics Before After Change
Lines 2044 2080 36
Changed files Quality Before Quality After Quality Change
blehid.py 74.26% 🙂 74.26% 🙂 0.00%
relaykeys-cli.py 41.79% 😞 41.79% 😞 0.00%
relaykeys-qt.py 54.59% 🙂 54.98% 🙂 0.39% 👍
relaykeysd.py 43.49% 😞 43.94% 😞 0.45% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
relaykeys-cli.py do_main 99 ⛔ 525 ⛔ 18 ⛔ 6.10% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
relaykeysd.py process_action 32 😞 332 ⛔ 17 ⛔ 17.50% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
relaykeysd.py rpc_server_worker 41 ⛔ 425 ⛔ 12 😞 19.05% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
relaykeys-qt.py Window.client_send_actions 36 ⛔ 206 ⛔ 17 ⛔ 21.54% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
relaykeys-qt.py Window.onKeyboardDown 35 ⛔ 207 ⛔ 15 😞 23.96% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@willwade willwade merged commit 2bfca82 into AceCentre:master Mar 23, 2022
gitbook-com bot pushed a commit that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants