fix/progress bar loop lock release #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukacan
changed the title
Ikrk
suggested changes
Feb 29, 2024
💬 Formated output text as warning
Ikrk
force-pushed
the
fix/progress-indicator-stuck
branch
from
fe3a5d9
to
0a16e0e
Compare
Ikrk
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a bug within the macro expansion process due to an incorrect lock release process. Specifically, the lock indicating the end of expansion was released after parsing the output. However, if the parsing process triggers a panic, it can prevent the lock from being released.
This PR solves the problem, the lock is released right after the expansion process.