Merge pull request #62 from AckeeCZ/feat/tests-2

Feat/tests 2

.github/workflows/test.yml

@@ -1,6 +1,6 @@
 name: Node.js CI
 
-on: [push, pull_request]
+on: [pull_request]
 
 jobs:
     build:

packages/@ackee/antonio-core/src/modules/request/utils/url/__tests__/createRequestUrl.test.ts

@@ -0,0 +1,25 @@
+import logger from 'loglevel';
+import { createRequestUrl } from '..';
+
+describe('createRequestUrl', () => {
+    it('composes request url', () => {
+        const url = createRequestUrl(
+            '/user/:id',
+            {
+                baseURL: 'https://example.com',
+                uriParams: {
+                    id: '2',
+                },
+                params: new URLSearchParams({
+                    page: '1',
+                }),
+                headers: {},
+            },
+            {
+                logger,
+            },
+        );
+
+        expect(url).toBe('https://example.com/user/2?page=1');
+    });
+});

packages/@ackee/antonio-core/src/modules/request/utils/url/__tests__/joinUrlChunks.test.ts

@@ -0,0 +1,9 @@
+import { joinUrlChunks } from '..';
+
+describe('joinUrlChunks', () => {
+    it('joins multiple pathnames with origin to create one URL', () => {
+        expect(joinUrlChunks('https://example.com/', '/a', 'b').toString()).toBe('https://example.com/a/b');
+        expect(joinUrlChunks('https://example.com', 'a').toString()).toBe('https://example.com/a');
+        expect(joinUrlChunks('https://example.com/')).toBeInstanceOf(URL);
+    });
+});

packages/@ackee/antonio-core/src/modules/request/utils/url/__tests__/uriParams.test.ts

@@ -0,0 +1,16 @@
+import { setUriParams } from '../uriParams';
+
+describe('uriParams', () => {
+    it('replaces :id token with actual value', () => {
+        const url = setUriParams('/users/:group/:id', {
+            id: 1,
+            group: 'alpha',
+        });
+
+        expect(url).toEqual('/users/alpha/1');
+    });
+
+    it(`throws an error if value for given token isn't provided`, () => {
+        expect(() => setUriParams('/users/:id', {})).toThrow(TypeError);
+    });
+});

packages/@ackee/antonio-core/src/modules/request/utils/url/index.ts

@@ -1,19 +1,19 @@
 import type { GeneralConfig } from '../../../core/general-config';
 
-import type { RequestConfig } from '../../../../types';
+import type { FinalRequestConfig } from '../mergeRequestConfigs';
 
 import { setUriParams } from './uriParams';
 
 const removeSlashAtStartAndAtEnd = (chunk: string) => chunk.replace(/^\/|\/$/g, '');
 
-function joinUrlChunks(baseUrl?: string, ...path: string[]) {
+export function joinUrlChunks(baseUrl?: string, ...path: string[]) {
     const joinedUrl = [baseUrl, ...path].filter(Boolean).map(removeSlashAtStartAndAtEnd).join('/');
     return new URL(joinedUrl);
 }
 
 export function createRequestUrl(
     requestUrl: string,
-    requestConfig: RequestConfig,
+    requestConfig: FinalRequestConfig,
     generalConfig: GeneralConfig,
 ): string {
     try {

packages/@ackee/antonio-core/src/types.ts

@@ -1,3 +1,4 @@
+import type { FinalRequestConfig } from 'modules/request/utils';
 import type { IterableStream } from './modules/response/iterableStream';
 
 export type Primitive = bigint | boolean | null | number | string | undefined;
@@ -180,6 +181,6 @@ export interface RequestResult<D = any> {
 
 export interface RequestParams {
     url: string;
-    config: RequestConfig;
+    config: FinalRequestConfig;
     bodyData: RequestBodyData;
 }