Do not log empty user agent

CHANGELOG.md

@@ -5,6 +5,7 @@
 - stream write function type
 - pretty streams created only when needed
 - logger name in pretty loggers
+- empty user-agent logged no more
 
 
 ### Added

src/express.ts

@@ -25,7 +25,8 @@ const expressOnHeaders = (req: AckeeRequest, res: AckeeResponse) => () => {
 
 const expressOnFinished = (logger: AckeeLogger, req: AckeeRequest) => (_err: Error | null, res: AckeeResponse) => {
     const error = res[errorSymbol];
-    const reqOut = `${res.statusCode} ${req.method} ${req.originalUrl} ${res.time} ms ${req.headers['user-agent']}`;
+    const userAgent = req.headers['user-agent'];
+    const reqOut = `${res.statusCode} ${req.method} ${req.originalUrl} ${res.time} ms ${userAgent ? userAgent : ''}`;
     if (logger.options.ignoredHttpMethods && logger.options.ignoredHttpMethods.includes(req.method)) {
         // left here for BC
         return;
@@ -57,7 +58,8 @@ const expressMiddleware: RequestHandler = function(
     response: AckeeResponse,
     next: any
 ) {
-    const reqIn = `--- ${req.method} ${req.originalUrl} ${req.headers['user-agent']}`;
+    const userAgent = req.headers['user-agent'];
+    const reqIn = `--- ${req.method} ${req.originalUrl} ${userAgent ? userAgent : ''}`;
     this.debug({ req, ackId: req.ackId }, `${reqIn} - Request accepted`);
     req._startAt = process.hrtime();
     onHeaders(response, expressOnHeaders(req, response));

src/tests/express.test.ts

@@ -133,3 +133,33 @@ test('route can be ignored using regexp helper', () => {
         expect(loggerWrites).not.toBeCalled();
     });
 });
+
+test('user-agent is logged', () =>
+    new Promise((resolve, reject) => {
+        const logger = loggerFactory({
+            streams: [testWriteStream(resolve, json => expect(json.message).toMatch('dummy agent'))],
+        });
+
+        const app = express();
+        const request = supertest(app);
+        app.use(logger.express);
+        request
+            .get('/test')
+            .set('User-Agent', 'dummy agent')
+            .then(() => null);
+    }));
+
+test('missing user-agent is not logged', () =>
+    new Promise((resolve, reject) => {
+        const logger = loggerFactory({
+            streams: [testWriteStream(resolve, json => expect(json.message).not.toMatch('undefined'))],
+        });
+
+        const app = express();
+        const request = supertest(app);
+        app.use(logger.express);
+        request
+            .get('/test')
+            .unset('User-Agent')
+            .then(() => null);
+    }));