Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add context details to Sentry logging #48

Merged
merged 15 commits into from
Oct 5, 2020
Merged

Conversation

vlasy
Copy link
Contributor

@vlasy vlasy commented Sep 16, 2020

No description provided.

Copy link
Contributor

@smolijar smolijar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few non-blocking questions.

src/sentry.ts Show resolved Hide resolved
src/sentry.ts Outdated Show resolved Hide resolved
src/sentry.ts Outdated Show resolved Hide resolved
@vlasy vlasy force-pushed the feat/sentry-message-details branch 2 times, most recently from 9dcab19 to ef2bc79 Compare September 22, 2020 09:49
@vlasy vlasy marked this pull request as ready for review September 22, 2020 14:18
@vlasy vlasy requested a review from smolijar September 22, 2020 14:21
Copy link
Contributor

@smolijar smolijar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request feedback on some CR. Also there are some comments left from previous review.

src/sentry.ts Show resolved Hide resolved
src/tests/index.test.ts Show resolved Hide resolved
src/sentry.ts Show resolved Hide resolved
src/tests/sentry-mocked.test.ts Show resolved Hide resolved
@smolijar smolijar self-requested a review October 5, 2020 10:54
@vlasy vlasy merged commit 582d433 into master Oct 5, 2020
@vlasy vlasy deleted the feat/sentry-message-details branch October 5, 2020 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants