Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiny new file watcher with --watch argument #120

Merged
merged 2 commits into from Feb 1, 2016
Merged

Conversation

yakovkhalinsky
Copy link
Contributor

Referencing issue #40

@yakovkhalinsky
Copy link
Contributor Author

Merging

yakovkhalinsky added a commit that referenced this pull request Feb 1, 2016
Shiny new file watcher with --watch argument
@yakovkhalinsky yakovkhalinsky merged commit 72f186f into master Feb 1, 2016
@shavo007
Copy link

shavo007 commented Feb 2, 2016

Hi @yakovkhalinsky ,

I updated the version of drakov to 0.2.1.

I see in the readme the new command to run for drakov:

drakov -f "../com/foo/contracts/*.md" --watch

i have an asynchronous grunt task already for drakov. I assumed that watch is just another option.

``
grunt.registerTask('mock-api', 'Start drakov server', function() {
var done = this.async();

var drakovOptions = {
  sourceFiles: './doc/*.md',
  serverPort: 3000,
  autoOptions: true,
  delay: 1000,
  watch: true
};

drakov.run(drakovOptions, function(err){
  console.log('-- STARTED --');
  if (err) {
    throw err;
  }
});
done();

});

``

I start the server and i make a change to the .md file. But the reload does not occur.

Am i missing something?

Thanks,
Shane.

@yakovkhalinsky
Copy link
Contributor Author

hi @shavo007 the watcher was implemented as a separate module to the core drakov module, which is why it doesn't work as a part of the main drakov.run command.

I'll have a look at this and see if I can implement the watcher implementation to make it work for your specific usecase.

@shavo007
Copy link

shavo007 commented Feb 2, 2016

No probs. You need me to create a new issue?

@yakovkhalinsky
Copy link
Contributor Author

@shavo007 I'll create a new PR and mention this PR, as well as ping you 👍

@shavo007
Copy link

shavo007 commented Feb 2, 2016

Thanks. Appreciate it.

@aj-jaswanth aj-jaswanth deleted the file-watcher branch January 12, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants