Added file driver for file based caching #34
Conversation
BRIMIL01
force-pushed
the
add_file_store_support
branch
from
799eb2f
to
558d05e
Compare
| def set(key, entity) | ||
| cache = { 'value' => entity.value } | ||
| if entity.expiration | ||
| expiration = Time.now.to_i + entity.expiration |
There was a problem hiding this comment.
you don't want to UTC this first?
There was a problem hiding this comment.
Figured since you were using it in the internal_timestamp probably would want to be consistent.
There was a problem hiding this comment.
Should I fix it in the in_memory_driver as well?
| return Hitnmiss::Driver::Miss.new if cached_entity.nil? | ||
|
|
||
| if cached_entity.has_key?('expiration') | ||
| if Time.now.to_i >= cached_entity['expiration'] |
There was a problem hiding this comment.
If the other expiration is UTC'd I would expect this one to be as well.
| options[:fingerprint] = cached_entity['fingerprint'] | ||
| end | ||
| if cached_entity.has_key?('updated_at') | ||
| options[:updated_at] = Time.parse(cached_entity['updated_at']) |
There was a problem hiding this comment.
I think this handles TZ correctly if I remember correctly.
| subject { Hitnmiss::FileDriver.new(folder) } | ||
|
|
||
| before do | ||
| subject |
There was a problem hiding this comment.
Are you using the construction of the class to do the mkdir_p?
| context 'when given entity has a last_modified' do | ||
| it 'caches the given value with key, expiration, and last_modified' do | ||
| entity = Hitnmiss::Entity.new('some_value', expiration: 1, | ||
| fingerprint: 'foofingerprint', |
There was a problem hiding this comment.
did you intend for fingerprint to be set here? It looks like from the description you don't care.
| context 'when given entity has a last_modified' do | ||
| it 'caches the given value with key, expiration, and last_modified' do | ||
| entity = Hitnmiss::Entity.new('some_value', | ||
| fingerprint: 'foofingerprint', |
There was a problem hiding this comment.
same question about caring about fingerprint in this test case.
| build_hit_keyword_args(cached_entity)) | ||
| end | ||
|
|
||
| def all(keyspace) |
There was a problem hiding this comment.
Don't we also need to take into consideration, expiration?
There was a problem hiding this comment.
Following the conventions in the in_memory_driver
| end | ||
|
|
||
| describe '#all' do | ||
| it 'returns only the values whose keys begin with the keyspace' do |
There was a problem hiding this comment.
I think this also needs to take into consideration if the entities are expired or not, and only return values for cached entities that haven't already expired.
|
👍 |
No description provided.