Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BankId login page isn't supported in Internet Explorer 11 #101

Closed
martinsjolanders opened this issue Mar 4, 2019 · 3 comments
Closed

BankId login page isn't supported in Internet Explorer 11 #101

martinsjolanders opened this issue Mar 4, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@martinsjolanders
Copy link
Contributor

IE11 don't have the required window.fetch and a polyfill is needed for those that wants to support it.

What area is it related to
Source

To Reproduce
Steps to reproduce the behavior:

  1. Go to /account/login
  2. Click on BankId(Other Device)
  3. A message stating "Your browser does not have the features required to use this login page." is showed.

Expected behavior
Page shows input for Personal Number and Sign In Button

Screenshots
image

Desktop (please complete the following information):

  • Win 10
  • IE
  • 11
@martinsjolanders martinsjolanders added the bug Something isn't working label Mar 4, 2019
@fredrik-lundin
Copy link
Contributor

A solution would be to just include the polyfill out of the box I guess? We can even make a code check for window.fetch and load the polyfill dynamically if needed.

Are there any considerations we should take, that might complicate things, or is this as straight forward as it seems?

@PeterOrneholm
Copy link
Member

A solution would be to just include the polyfill out of the box I guess? We can even make a code check for window.fetch and load the polyfill dynamically if needed.

I've considered it, but would like to avoid it. Active Login UI is rendered in the context of the current app, so when IE11 needs to be supported, such polyfill might already be available. Also, we would need to choose one specific and I'd like to not take dependencies on to many external stuff, as these usually are opinionated. Especiially in the cases when you don't need to support IE11. It seems alot are using this for logging in through an app, and then Chrome/Safari are the only browsers they need to support.

Adding a FAQ for this is my suggestion, and there we could point to one specific polyfill that people can use. Maybe also updating our sample with this.

@fredrik-lundin
Copy link
Contributor

@PeterOrneholm I think you are right - we probably shouldn't include the polyfill by default. I've looked around some other projects, and it seems to be common practice not to include it.

What we probably should do is have a section about browser compatibility/supported browsers in our readme file, where information about polyfills needed for older browsers should be included.

PeterOrneholm pushed a commit that referenced this issue Mar 6, 2019
* Added documentation about browser support

* Reformat polyfill text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants