Moved the metadata into setup.cfg #127
Conversation
setup.py
Outdated
| for line in read("appdirs.py").splitlines(): | ||
| if line.startswith("__version__"): | ||
| version = ast.literal_eval(line.split("=", 1)[1].strip()) | ||
| break |
There was a problem hiding this comment.
Please notice the inconsistency in indentation here. I also believe that double blank lines was to separate the lengthy setup call from the preparation part (sort-of), so in this case it might not be necessary.
| def read(fname): | ||
| inf = open(os.path.join(os.path.dirname(__file__), fname)) | ||
| inf = open(os.path.join(current_dir, fname), "rt", encoding="utf-8") |
There was a problem hiding this comment.
rt are default for open, so IMHO there won't be any gain being that explicit here. Additionally, if this gets merge,, the only call for read is to get the version, thus the code below could be refactored to
with open(os.path.join(op.path.dirname(__file__), "appdirs.py")) as source:
version = next(ast.literal_eval(line.split("=", 1)[1].strip())
for line in source if line.startswith("__version__"))|
|
||
| setup_requires = setuptools>=30.3.0; wheel |
There was a problem hiding this comment.
I just want to remind you about b68a72e that setuptools is actually not required. Though, if distutils reads the setup_requires option or not, I am not exactly sure. Forgive me if it does not.
Added pyproject.toml to allow building with `build`.
|
I'd recommend to close this in favor of #136. |
No description provided.