Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat empty environment variables like unset ones #131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Treat empty environment variables like unset ones #131

wants to merge 2 commits into from

Conversation

clbarnes
Copy link

@clbarnes clbarnes commented Feb 19, 2020 •
edited
Loading

See #130

As per the XDG spec. Previously, empty variables would be used as-is.

Breaking change, but necessary for spec compliance.

@clbarnes
Treat empty environment variables like unset ones
57c8910 
As per the XDG spec. Previously, empty variables would be used as-is.
McSinyx
McSinyx suggested changes Feb 20, 2020
View reviewed changes
Copy link

@McSinyx McSinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm favoring this change (although I'm not somebody in charge if that's not obvious) but a few tiny details.

appdirs.py Outdated Show resolved Hide resolved
appdirs.py Outdated Show resolved Hide resolved
@clbarnes
Empty environment variable: review comments
3a40b2b 
* Shorten getenv function
* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McSinyx McSinyx McSinyx requested changes

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clbarnes @xavfernandez @McSinyx