Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved serious ReDoS in PunktSentenceTokenizer (#2869) #3

Merged
merged 1 commit into from Dec 21, 2023

Conversation

icanhasmath
Copy link
Collaborator

  • Resolved serious ReDOS in PunktSentenceTokenizer

  • Improve performance by relying on string split instead of re.search

  • Solved issue if sentence contains just one token

* Resolved serious ReDOS in PunktSentenceTokenizer

* Improve performance by relying on string split instead of re.search

* Solved issue if sentence contains just one token
@icanhasmath icanhasmath merged commit 7aad6f6 into 3.4.5.x Dec 21, 2023
@icanhasmath icanhasmath deleted the cve-2021-43854 branch December 21, 2023 19:44
Copy link

@rickprice rickprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants