Added fields injection for the delegate instance loaded when handling si... #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… signals The delegate instance used when handling a signal could be different than the one used when the execution has been handled (like a new instance), so there is the need to re-inject fields expressions otherwise they could be not accessible by the instance handling the signal
|
Related Jira issue: http://jira.codehaus.org/browse/ACT-1788 |
|
Delegate instances are supposed to be stateless... All members are injected using Expression objects, which should be evaluated on a per-execution basis. So if all went well, the injection happened when the delegate was created and shouldn't be repeated ever. Can you elaborate if I'm missing something here? |
|
Just replied on the Jira issue: https://jira.codehaus.org/browse/ACT-1788 |
frederikheremans
added a commit
that referenced
this pull request
Oct 1, 2013
Added fields injection for the delegate instance loaded when handling si...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delegate instance used when handling a signal could be different than the one used when the execution has been handled (like a new instance), so there is the need to re-inject fields expressions otherwise they could be not accessible by the instance handling the signal