Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-19479 Register a new primitive type for decimal #4543

Merged

Conversation

tom-dal
Copy link
Contributor

@tom-dal tom-dal commented Jan 18, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

Description

  • Issue Link:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@eromano
Copy link
Contributor

eromano commented Jan 19, 2024

@tom-dal can you check the right name should not be bigdecimal https://github.com/Activiti/Activiti/blob/develop/activiti-core/activiti-engine/src/main/java/org/activiti/engine/impl/variable/BigDecimalType.java ?

Copy link
Contributor

@mavotto mavotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-dal tom-dal merged commit c233e96 into develop Jan 25, 2024
5 checks passed
@tom-dal tom-dal deleted the dev-tdalessandro-aae-19479-add-decimal-primitive-type branch January 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants