MNT-24081: executionListeners executed when process instance is delet… #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemedeiros
approved these changes
Feb 8, 2024
Comment on lines
+428
to
+434
| // Execute execution listeners for process end. | ||
| Process process = ProcessDefinitionUtil.getProcess(processInstanceExecutionEntity.getProcessDefinitionId()); | ||
| if (CollectionUtil.isNotEmpty(process.getExecutionListeners())) { | ||
| executeExecutionListeners(process, | ||
| processInstanceExecutionEntity, | ||
| ExecutionListener.EVENTNAME_END); | ||
| } |
There was a problem hiding this comment.
Suggestion for future developments: prefer to extract a method with a meaningful name instead of using a comment to tell what the code block does.
There was a problem hiding this comment.
Thanks for the input, it's a good contribution for CI: Continuous Improvement 👍
vrmoreira
deleted the
fix/MNT-24081-END-Execution-Listener-attached-to-the-process-instance-is-not-called_develop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed (#4572)
(cherry picked from commit 8459aef)
What kind of change does this PR introduce?
Description
Does this PR introduce a breaking change? (check one with "x")