This repository has been archived by the owner on May 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
fix(AAE-1207): Updated graphql-jpa-query version to 0.4.0 #234
Merged
mergify
merged 4 commits into
develop
from
fix-AAE-1207-update-graphql-jpa-query-version
Jan 23, 2020
Merged
fix(AAE-1207): Updated graphql-jpa-query version to 0.4.0 #234
mergify
merged 4 commits into
develop
from
fix-AAE-1207-update-graphql-jpa-query-version
Jan 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 65.59% 63.8% -1.8%
+ Complexity 207 188 -19
===========================================
Files 48 44 -4
Lines 1180 1105 -75
Branches 87 82 -5
===========================================
- Hits 774 705 -69
+ Misses 355 353 -2
+ Partials 51 47 -4
Continue to review full report at Codecov.
|
igdianov
force-pushed
the
fix-AAE-1207-update-graphql-jpa-query-version
branch
from
January 23, 2020 07:19
cd1febe
to
2cce1d9
Compare
eromano
approved these changes
Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
graphql-jpa-query
dependencies in order to fix GraphQL JPA query memory leaks caused by JPA provider paginated collection fetch:HHH000104: firstResult/maxResults specified with collection fetch; applying in memory!
It also removes redundant implementations of GraphQLController and GraphQLSchema auto configuration managed by
graphql-jpa-query-web
andgraphql-jpa-query-autoconfigure
modules.I have built the preview and tested the fix for Notification GraphQL Query running out of memory problem with Activiti Cloud Helm deployment in K8s against 130,000 tasks in the Postgresql Query database: AlfrescoArchive/activiti-cloud-notifications-graphql#314
The Gatling load test simulation was running task query below with collection fetches for 100 random pages with 100 limit by ramping concurrent users from 1 to 100 during 3 minutes time period:
There is a total of 5511 requests reported 100% successful response, with 95th percentile having 1464ms response time (i.e. 5% of requests had response time more than 1.4 seconds)
Fixes AAE-1207