Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrete Choice Model Capabilities #3

Closed
jiffyclub opened this issue Dec 5, 2014 · 4 comments
Closed

Discrete Choice Model Capabilities #3

jiffyclub opened this issue Dec 5, 2014 · 4 comments
Assignees

Comments

@jiffyclub
Copy link
Contributor

UrbanSim has location choice models, but they are somewhat specialized to their application in real estate modeling. (For example, the LCMs always remove choices from the alternatives pool once they have been chosen.) As a first step toward adding models to ActibitySim we're working to generalize the discrete choice classes in UrbanSim so that they can be reused here. You can follow my work in the dcm branch in UrbanSim.

Also related to this, we've added tests of UrbanSim's MNL implementation to make sure it matches R's mlogit package. You can see that work in UDST/urbansim#132.

@jiffyclub
Copy link
Contributor Author

I've opened UDST/urbansim#134 with the changes to support more general discrete choice modeling in urbansim.

@fscottfoti
Copy link
Contributor

Is there any reason not to merge the DCM branch on UrbanSim and close this issue? I do use the changes in the MNL interaction in activitysim so it would be handy to depend on master rather than depending on the dcm branch.

@jiffyclub
Copy link
Contributor Author

Yeah if you're using it let's merge it. I wasn't sure if any of the changes were actually being used.

@fscottfoti
Copy link
Contributor

Sounds good - merge away!

bstabler pushed a commit that referenced this issue May 12, 2017
bstabler added a commit that referenced this issue Aug 11, 2020
* move other resources into folder since examples now part of package as well

* Add new skim lookups for the TNC bridge tolls return charges below.
- odr - origin to destination reverse
- dor - destination to origin reverse

TNC revisions:
- Update TNC bridge tolls so return charges are included
- Added ride-hail single and taxi constants for trip mode choice within ride-hail tour mode choice
- Reduced TNC wait time mean and sd slightly to in the highest density category
- Turned on origin density index constant (already used for walk, bike and walk-transit modes) for TNC single and TNC shared

* allow for a small number of stop locations within walking distance

* updated tnc ascs from tm 1.5 run

* add notebooks

* add readme for notebooks folder

* Interactive tutorial (#3)

* Add verification jupyter notebook

* add shapefile

* code review

* cleanup

* update shapefile note

Co-authored-by: Ben Stabler <bstabler@users.noreply.github.com>
Co-authored-by: bstabler <benstabler@yahoo.com>

* clean up folder setup

* finish summaries notebook

* updated getting started tutorial

* continue work on the recipe book

* estimation notebooks for larch (#19)

* notebooks for auto ownership and workplace location estimation

* minimally functional larch estimation mode notebooks

includes auto ownership, workplace location, tour mode
requires larch >= 5.3.7

* revised notebooks

uses new EDB for tour_mode_choice

* update example EDBs and estimation notebooks

* Fix tour mode choice notebook (#20)

Fill in missing values in values DataFrame

* update notebook

* update getting started notebook

* more notebook updates

* notebook for estimating school location (#21)

* create two and three zone test data, see also https://github.com/ActivitySim/activitysim/wiki/Multiple-Zone-Systems-Design

* update notebook markdown

* after merge from develop, resolve conflicts, pycodestyle, and add header to school location notebook

* small doc fix

* update tests EXPECT_TOUR_COUNT

* resolve conflict

Co-authored-by: Blake <blake.rosenthal@rsginc.com>
Co-authored-by: Jeffrey Newman <jeff@newman.me>
Co-authored-by: Jeff Doyle <toliwaga@gmail.com>
jpn-- pushed a commit that referenced this issue Apr 12, 2022
simwrapper is on conda-forge now; remove pip install rules & docs
jpn-- pushed a commit that referenced this issue Apr 1, 2024
* CDAP estimation with joint component

* fixing person_rank call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants