Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-coded household ID field name in summarize.py #103

Closed
binnympaul opened this issue Jan 22, 2020 · 0 comments · Fixed by #110
Closed

Hard-coded household ID field name in summarize.py #103

binnympaul opened this issue Jan 22, 2020 · 0 comments · Fixed by #110
Assignees
@blakerosenthal
Labels
bug enhancement

Comments

@binnympaul
Copy link
Collaborator

Hard-coded field name for household ID is being used in summarize.py.

This forces users to name the unique household ID as 'hh_id' in seed_households file. The code must get the household_id_col name from the settings.yaml file.
@blakerosenthal blakerosenthal mentioned this issue Feb 19, 2020
Merged
@blakerosenthal blakerosenthal linked a pull request Feb 19, 2020 that will close this issue
Fixes #110
Merged
bstabler pushed a commit that referenced this issue Feb 21, 2020
Fixes (#110)
7abd9d4 
* ActivitySim 0.9.2; Pandas 1.0

* Freeze ortools package below 7.5

* fix issue #103

* fix issue #102
bstabler added a commit that referenced this issue Feb 21, 2020
@bstabler @gregmacfarlane
various updates (#111)
9b29db4 
* Package updates (#109)

* ActivitySim 0.9.2; Pandas 1.0

* Freeze ortools package below 7.5

* Add info about zero-person households (#106)  

This addresses the documentation needs arising from #104

* Fixes (#110)

* ActivitySim 0.9.2; Pandas 1.0

* Freeze ortools package below 7.5

* fix issue #103

* fix issue #102

* Update setup.py (#112)

Co-authored-by: Blake <brosenthalpdx@gmail.com>
Co-authored-by: Greg Macfarlane <gregmacfarlane@gmail.com>
bstabler added a commit that referenced this issue May 12, 2020
@bstabler @gregmacfarlane
Develop (#120)
c9e54f6 
* Package updates (#109)

* ActivitySim 0.9.2; Pandas 1.0

* Freeze ortools package below 7.5

* Add info about zero-person households (#106)

This addresses the documentation needs arising from #104

Co-authored-by: Ben Stabler <bstabler@users.noreply.github.com>

* Fixes (#110)

* ActivitySim 0.9.2; Pandas 1.0

* Freeze ortools package below 7.5

* fix issue #103

* fix issue #102

* Update setup.py (#112)

* Pypi cleanup (#114)

* pypi cleanup

* remove rst file

* Add validation notebook (#119)

Co-authored-by: Blake <blake.rosenthal@rsginc.com>
Co-authored-by: Greg Macfarlane <gregmacfarlane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakerosenthal blakerosenthal

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes
3 participants
@bstabler @binnympaul @blakerosenthal