Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity not showing in window tab after 00:00 AM #508

Closed
1ncend1ary opened this issue Nov 17, 2020 · 9 comments
Closed

Activity not showing in window tab after 00:00 AM #508

1ncend1ary opened this issue Nov 17, 2020 · 9 comments

Comments

@1ncend1ary
Copy link

Which version of ActivityWatch are you running?

  • Version: v0.9.2

What made the issue/bug appear? (steps to reproduce)

  • Install ActivityWatch
  • Go to Settings, set Start of day to 04:00 AM (may be the default setting)
  • Open Activity->Window
  • The Window is not showing data past 00:00 AM even if there was no activity the day before. Also, the data from the previous day is not overriden by new data

Include a logfile

  • I thnik the logfile is irrelevant, but can provide it if necessary

In the screenshot you can see how there is no activity recorded between 00:00 and Now.
image

@johan-bjareholt
Copy link
Member

johan-bjareholt commented Nov 18, 2020

The Window is not showing data past 00:00 AM even if there was no activity the day before. Also, the data from the previous day is not overriden by new data

I'm not sure what you mean by this, what does the day before have to do with the day you have selected? And day before what, today or before the selected day in the web-ui?

Some clarification is needed here.

@ErikBjare
Copy link
Member

ErikBjare commented Nov 18, 2020

@johan-bjareholt I think he simply means that the Start of Day setting isn't being respected by the sunburst visualization, which is correct. Also, when changing the day the visualization doesn't update.

However, since the sunburst vis is being deprecated in v0.10 (although perhaps temporarily), this issue isn't really going to be fixed, but I'll make a mental note of it in case we reintroduce it.

@1ncend1ary
Copy link
Author

Yes, EricBjare is correct in their interpretation of the issue.

Sorry, I didn't know that the correct term was "sunburst" neither did I know that the feature was deprecated.

I think I will close this issue due to no further activity possible, and will see if I can contribute. Thanks.

@sojusnik
Copy link

However, since the sunburst vis is being deprecated in v0.10 (although perhaps temporarily), this issue isn't really going to be fixed, but I'll make a mental note of it in case we reintroduce it.

Please don't remove the sunburst view, since it's the main reason I use your great program. What is the rationale to remove it at all? It's so useful to see your activity during the whole day at a glance!

@ErikBjare
Copy link
Member

@sojusnik It was removed in a recent PR overhauling the views (Summary/Window/Browser/etc). See this comment noticing its deprecation: ActivityWatch/aw-webui#233 (comment)

The rationale was really a technical one. It is one of our oldest visualizations, and it carries a fair bit of technical debt (leading to bugs like the ones reported here) that would take some work to clean up.

Apart from the in-the-moment decision to drop it in order to speed up the merge of the PR, we've been meaning to add better ways to get an overview of your whole day. As an example, in the above PR we added the barchart visualization (see screenshots in the PR), which we intend to improve by letting it show stacked bars with time spent per category.

We welcome PRs to get it cleaned up and readded, but if you can't and really value it we suggest not updating until it has been reintroduced.

@sojusnik
Copy link

We welcome PRs to get it cleaned up and readded, but if you can't and really value it we suggest not updating until it has been reintroduced.

Let's hope that this happens soon 🤞

@ErikBjare
Copy link
Member

ErikBjare commented Jan 2, 2021

The sunburst clock visualization was reintroduced in ActivityWatch/aw-webui#244 and will be back in the next release!

The 00:00 bug should also be resolved (but not tested).

@sojusnik
Copy link

sojusnik commented Jan 2, 2021

The best news in the new year, thanks!

@JFMugen
Copy link

JFMugen commented Jan 14, 2022

The sunburst clock visualization was reintroduced in ActivityWatch/aw-webui#244 and will be back in the next release!

The 00:00 bug should also be resolved (but not tested).

Looks like 00:00 bug is not fixed :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants