fix: refactored flood to better behavior #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 90.78% 90.16% -0.63%
==========================================
Files 34 34
Lines 1660 1687 +27
Branches 257 262 +5
==========================================
+ Hits 1507 1521 +14
- Misses 118 131 +13
Partials 35 35
Continue to review full report at Codecov.
|
2 tasks
2 tasks
|
Since this is based on the aw-server-rust implementation, I just want to note that it might not be without issues either: ActivityWatch/activitywatch#602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had this in my working tree for a while. Should be improved behavior better aligned with how aw-server-rust works. Will hopefully fix ActivityWatch/activitywatch#626.
(Needs thorough review, long time since I wrote this, and can't remember what I've done)