fix: fixed compilation warnings & deprecations

[ErikBjare]

🚀 This description was created by Ellipsis for commit 437fcd6

Summary:

Comprehensive update and cleanup of the codebase, addressing compilation warnings, deprecations, and improving efficiency across multiple modules.

Key points:

• Removed unused imports across multiple files.
• Updated deprecated function calls to their newer alternatives.
• Changed function parameters from owned strings to string slices to improve efficiency.
• Fixed issues with incorrect or outdated function calls and types, aligning with current library versions.
• Enhanced code readability and performance by removing redundant code and optimizing data handling.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4b62c89 in 1 minute and 18 seconds

More details

• Looked at 311 lines of code in 9 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. aw-server/src/endpoints/bucket.rs:55

• Draft comment:
  The conversion from &str to String using to_string() is necessary here because the Bucket struct expects a String type for the id field. This change is consistent with the intent to use string slices for function parameters to avoid unnecessary cloning, but conversion is needed for compatibility with existing data structures.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR description is empty, which makes it difficult to understand the specific intent behind the changes. However, the changes in the PR seem to focus on removing unused imports, updating deprecated methods, and improving the handling of string parameters in function calls. The changes in the aw-server/src/endpoints/bucket.rs file, where String parameters are changed to &str, are particularly notable. This change is beneficial as it avoids unnecessary cloning of strings, which can improve performance. However, there are instances where the conversion back to String is done, such as in bucket_new function where bucket.id = bucket_id.to_string(); is used. This conversion is necessary because the Bucket struct likely expects a String type for the id field. Overall, the changes seem to be well-intentioned to clean up the code and update deprecated functionalities.

Workflow ID: wflow_rPLZWiW5HUNbNrJT

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 9 days left in your free trial, upgrade for $20/seat/month or contact us.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 437fcd6 in 1 minute and 44 seconds

More details

• Looked at 15 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. aw-sync/src/sync.rs:282

• Draft comment:
  The removal of explicit datastore close calls might lead to resource leaks or unintended behavior. If the datastores are expected to be explicitly closed after operations, this change could potentially keep connections open longer than necessary, affecting performance and resource management. Please ensure that all resources are properly managed and closed.
• Reason this comment was not posted:
  Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_XSxq9rGFGp0OwaZg

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 9 days left in your free trial, upgrade for $20/seat/month or contact us.