Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macos): get Firefox title when multiple instances are running #61

Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix(macos): get Firefox title when multiple instances are running #61

merged 1 commit into from
Jan 5, 2022

Conversation

Valentin-N
Copy link
Contributor

@Valentin-N Valentin-N commented Jan 4, 2022 •
edited by ErikBjare
Loading

Fixes ActivityWatch/activitywatch#538

Running printAppStatus.jxa manually:

  • Before:
./printAppStatus.jxa: execution error: Error: Error: Can't get object. (-1728)
  • After:
{"app":"Firefox Developer Edition","title":"Window titles not visible when running Firefox and Firefox Dev Edition · Issue #538 · ActivityWatch/activitywatch"}

@ErikBjare
Copy link
Member

Very nice, thanks!

@ErikBjare ErikBjare changed the title Fix Firefox title when multiple instances are running fix(macos): get Firefox title when multiple instances are running Jan 5, 2022
@ErikBjare ErikBjare merged commit 8f3c65d into ActivityWatch:master Jan 5, 2022
@Valentin-N Valentin-N deleted the fix_firefox_title branch January 5, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window titles not visible when running Firefox and Firefox Dev Edition
2 participants
@Valentin-N @ErikBjare