Skip to content

Commit

Permalink
test: increased timeouts for screenshot tests (hopefully fixing visua…
Browse files Browse the repository at this point in the history
…lizations that haven't yet rendered)
  • Loading branch information
ErikBjare committed Aug 16, 2022
1 parent c1371eb commit 3aaab25
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/e2e/screenshot.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ async function waitForLoading(t) {
let $loading;
console.log('Waiting for loading to disappear...');
do {
$loading = Selector('div', { timeout: 100 }).withText(/.+[Ll]oading.+/g);
await t.wait(200);
await t.wait(500);
$loading = Selector('div', { timeout: 500 }).withText(/.+[Ll]oading.+/g);
} while ((await $loading.count) >= 1);
await t.wait(500); // wait an extra 500ms, just in case a visualization is still rendering
console.log('Loading is gone!');
}

Expand Down

1 comment on commit 3aaab25

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are screenshots of this commit:

Screenshots using aw-server v0.12.0b2 (click to expand)

Screenshots using aw-server-rust master (click to expand)

Screenshots using aw-server-rust v0.12.0b2 (click to expand)

CML watermark

Please sign in to comment.