Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ability to edit events from timeline view #320

Merged
merged 5 commits into from
Mar 3, 2022

Conversation

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #320 (f65a035) into master (6fbe829) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   16.33%   16.33%           
=======================================
  Files          24       24           
  Lines        1157     1157           
  Branches      127      127           
=======================================
  Hits          189      189           
  Misses        924      924           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fbe829...f65a035. Read the comment docs.

@johan-bjareholt
Copy link
Member

Can this be an issue when editing events at the end/start of the current start time/endtime. Not sure if it applies to both aw-server-python and aw-server-rust, but I'm quite certain that it at least applies for aw-server-rust since it cuts the starttime or duration if it is outside starttime or endtime to give more accurate results.

@johan-bjareholt
Copy link
Member

That's also the reason why we didn't end up adding support for editing in the search view.

@ErikBjare
Copy link
Member Author

@johan-bjareholt Ah, yeah that's right. I'll look into a way to get the full event to be edited.

@ErikBjare
Copy link
Member Author

@johan-bjareholt I've now added a API to aw-server and aw-server-rust to fetch a single event by its ID, and will use that to fetch the full event to be edited.

@ErikBjare ErikBjare merged commit 5ace2bf into master Mar 3, 2022
@ErikBjare ErikBjare deleted the dev/edit-timeline branch March 3, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants