-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ability to edit events from timeline view #320
Conversation
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 16.33% 16.33%
=======================================
Files 24 24
Lines 1157 1157
Branches 127 127
=======================================
Hits 189 189
Misses 924 924
Partials 44 44 Continue to review full report at Codecov.
|
Can this be an issue when editing events at the end/start of the current start time/endtime. Not sure if it applies to both aw-server-python and aw-server-rust, but I'm quite certain that it at least applies for aw-server-rust since it cuts the starttime or duration if it is outside starttime or endtime to give more accurate results. |
That's also the reason why we didn't end up adding support for editing in the search view. |
@johan-bjareholt Ah, yeah that's right. I'll look into a way to get the full event to be edited. |
@johan-bjareholt I've now added a API to aw-server and aw-server-rust to fetch a single event by its ID, and will use that to fetch the full event to be edited. |
2c86cda
to
f65a035
Compare
Requires the following to fetch single events by ID (needed for editing events cut off by query):