Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: settings store #327

Merged
merged 10 commits into from
Mar 15, 2022
Merged

refactor: settings store #327

merged 10 commits into from
Mar 15, 2022

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Mar 15, 2022

Continuing on #306

What works:

  • All settings now live in the Vuex store
  • Slightly better testing, including access to Vuex state in NewReleaseNotification test
  • Updated versions of several packages

What doesn't work yet:

  • Storing settings on server (todo later)
    • Should be pretty easy to fix now that settings are centrally managed

aaayushsingh and others added 5 commits March 15, 2022 08:38
added overflow: visible; to VisTimeline.vue to allow tooltip to overflow the container
remove unwanted z-index change from tooltip.js
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #327 (f59a277) into master (b27a951) will increase coverage by 1.82%.
The diff coverage is 34.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   15.91%   17.73%   +1.82%     
==========================================
  Files          24       25       +1     
  Lines        1194     1263      +69     
  Branches      134      165      +31     
==========================================
+ Hits          190      224      +34     
- Misses        959     1001      +42     
+ Partials       45       38       -7     
Impacted Files Coverage Δ
src/main.js 0.00% <ø> (ø)
src/store/index.js 100.00% <ø> (ø)
src/store/modules/activity.ts 5.64% <0.00%> (-0.24%) ⬇️
src/util/tooltip.js 0.00% <ø> (ø)
src/visualizations/periodusage.js 0.00% <ø> (ø)
src/visualizations/summary.js 0.00% <ø> (ø)
src/visualizations/sunburst-clock.js 0.00% <ø> (ø)
src/visualizations/timeline-simple.js 0.00% <0.00%> (ø)
src/visualizations/timeline.js 0.00% <ø> (ø)
src/util/time.ts 26.19% <26.19%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27a951...f59a277. Read the comment docs.

@ErikBjare
Copy link
Member Author

Might be a few bugs hiding in here, but merging for now as it's such a big improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants