Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated design of 'Raw data' (Buckets) view #448

Merged
merged 3 commits into from
May 29, 2023

Conversation

ErikBjare
Copy link
Member

No description provided.

@ErikBjare ErikBjare force-pushed the dev/buckets-refresh branch 2 times, most recently from 1eeaedf to 070d455 Compare May 22, 2023 10:03
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 3.33% and project coverage change: -0.05 ⚠️

Comparison is base (6468b39) 24.22% compared to head (2e6f0c9) 24.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   24.22%   24.17%   -0.05%     
==========================================
  Files          27       27              
  Lines        1540     1580      +40     
  Branches      251      263      +12     
==========================================
+ Hits          373      382       +9     
- Misses       1142     1173      +31     
  Partials       25       25              
Impacted Files Coverage Δ
src/stores/buckets.ts 5.20% <3.33%> (-0.59%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErikBjare ErikBjare force-pushed the dev/buckets-refresh branch 2 times, most recently from 0402779 to 509a0dd Compare May 22, 2023 10:48
src/stores/buckets.ts Outdated Show resolved Hide resolved
src/stores/buckets.ts Outdated Show resolved Hide resolved
src/stores/buckets.ts Outdated Show resolved Hide resolved
@ErikBjare
Copy link
Member Author

CI won't be passing until either:

  • CI is using a version of aw-server that supports the device_id field (recent beta).
  • The /buckets/ integration test should probably be modified.

@ErikBjare ErikBjare merged commit 5484d68 into master May 29, 2023
7 checks passed
@ErikBjare ErikBjare deleted the dev/buckets-refresh branch May 29, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant