fix: correctly convert words from map to array
#569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ae09570 in 34 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/views/settings/CategoryBuilder.vue:156
- Draft comment:
The change from treatingwordsas an object to treating it as a Map is consistent with the usage in thefetchWordsmethod wherewordsis defined as a Map. This update ensures that the methods used for conversion and manipulation are appropriate for a Map data structure. - Reason this comment was not posted::
Confidence changes required:0%
The PR changes the waywordsare converted from a Map to an array. The original code seems to have treatedwordsas an object, but the new code treats it as a Map. This change is crucial because the methods used (Object.valuesvs.Map.prototype.values) are specific to the data structure type. The PR author has changed the type ofwordsfrom an object to a Map in thefetchWordsmethod (line 242). This change is consistent throughout the code, and the new method of conversion using[...this.words.values()]is correct for a Map. The PR description and linked issues do not provide specific details about why this change was necessary, but it seems to be a correction to align with the actual data structure used in the codebase.
Workflow ID: wflow_CB1N3IUTvCHpWMg1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 11 days left in your free trial, upgrade for $20/seat/month or contact us.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
=======================================
Coverage 25.60% 25.60%
=======================================
Files 27 27
Lines 1613 1613
Branches 273 273
=======================================
Hits 413 413
Misses 1174 1174
Partials 26 26 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested, works :)
Summary:
Fixes the conversion of
wordsfromMapto array inCategoryBuilder.vueto ensure correct UI functionality.Key points:
words_by_durationinCategoryBuilder.vueto correctly convertMapto array using spread operator.Generated with ❤️ by ellipsis.dev