Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark mode (Stopwatch, Category Builder) #570

Merged
merged 4 commits into from
May 9, 2024

Conversation

BelKed
Copy link
Contributor

@BelKed BelKed commented May 9, 2024

Screenshot 2024-05-09 at 05 16 42 Screenshot 2024-05-09 at 05 16 51


Screenshot 2024-05-09 at 05 17 17 Screenshot 2024-05-09 at 05 17 40



🚀 This description was created by Ellipsis for commit 220d65a

Summary:

This PR enhances dark mode support by fixing UI inconsistencies in the Stopwatch and Category Builder components.

Key points:

  • Added .stopwatch-entry class in StopwatchEntry.vue for dark mode hover effect.
  • Added .category-builder-word class in CategoryBuilder.vue for hover effect and table border color adjustments.
  • Updated dark.css to include styles for new classes and adjusted existing styles for better dark mode support.

Generated with ❤️ by ellipsis.dev

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 220d65a in 55 seconds

More details
  • Looked at 60 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_hsDXa8W2qVJ93pr9


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

11 days left in your free trial, upgrade for $20/seat/month or contact us.

static/dark.css Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.60%. Comparing base (9896601) to head (80384ac).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   25.54%   25.60%   +0.06%     
==========================================
  Files          27       27              
  Lines        1617     1613       -4     
  Branches      273      286      +13     
==========================================
  Hits          413      413              
+ Misses       1178     1174       -4     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare merged commit 8245c37 into ActivityWatch:master May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dark color theme has missing colors
2 participants