fix: only save updated settings to server, store theme and landingpage in localStorage as well

[ErikBjare]

Fixes #568

---

🚀 This description was created by Ellipsis for commit fbe6019

Summary:

This PR optimizes settings handling by removing unused code, refactoring state management, and ensuring crucial settings are stored locally for immediate access.

Key points:

• Removed unused code and refactored state handling in UserSatisfactionPoll.vue.
• Added JSON comparison function jsonEq in settings.ts to optimize settings storage.
• Implemented conditions to prevent unnecessary saving of default or unchanged settings in settings.ts.
• Ensured theme and landing page settings are stored in localStorage for immediate access.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to fbe6019 in 1 minute and 21 seconds

More details

• Looked at 181 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. src/components/UserSatisfactionPoll.vue:106

• Draft comment:
  Removing the initialization of data in the mounted hook assumes that the store always correctly initializes data. Consider adding error handling or a fallback mechanism to ensure data is correctly initialized to prevent potential runtime errors.
• Reason this comment was not posted:
  Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_UiKlvVh9keQhJ1aS

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 9 days left in your free trial, upgrade for $20/seat/month or contact us.

[codecov]

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 26.15%. Comparing base (bf16309) to head (fbe6019).

Files	Patch %	Lines
src/stores/settings.ts	10.52%	15 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   26.28%   26.15%   -0.14%     
==========================================
  Files          27       27              
  Lines        1613     1629      +16     
  Branches      276      285       +9     
==========================================
+ Hits          424      426       +2     
- Misses       1132     1145      +13     
- Partials       57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.