Mike feature/split crawler logging #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per toddy's request. OFAScraper now belongs to Dao
The output was producing incorrect results. Should be fixed now.
Split up the crawler and scraper to create more specialized module's.
Changed how description is written in output.
Code was only looking at 1 url no matter what. now its fixed.
Logging done, need review.
MikeJLeon
requested review from
daonguyen81,
kyrrahnork,
mrvirus9898,
rberry206,
TyReed12 and
a team
rberry206
approved these changes
Feb 19, 2019
Felt I needed to switch the name now.
daonguyen81
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crawler was split for Dao and I added proper logging. Please review.