Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erik feature #25

Merged
merged 6 commits into from
Mar 2, 2019
Merged

Erik feature #25

merged 6 commits into from
Mar 2, 2019

Conversation

erikNeville
Copy link
Contributor

I have connected links from the dashboard to an API using mockaroo, a fake API builder used for testing. Right now when a link from the dashboard is clicked, data is loaded into the details page of the app. This works by fetching the API from the URL, then getting an API response, receiving JSON data, then using the setState() method to update the state of the object that will be displayed. I'm storing the props id in a variable called id, and the specific event id in a variable called eventID. I then compare the two in order to tell the app which event to display.

…dashboard. Didn't get it, but reverted to how it was
… fake API when clicking an event on the dashboard
@coultergeist
Copy link
Contributor

Conflicts in db.json. It looks to me like you only added to the existing file so could we try and solve those conflicts before we review? Let me know if there are problems. It looks good at first glance, otherwise.

@hkhual hkhual self-requested a review March 2, 2019 23:02
Copy link
Contributor

@hkhual hkhual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the merge conflict and tested Erik Feature's branch on my local machine, everything work fine. Can merge.

@hkhual hkhual requested a review from bradleyshao March 2, 2019 23:07
Copy link
Contributor

@bradleyshao bradleyshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. no conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants