Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erik feature #27

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Erik feature #27

merged 2 commits into from
Mar 5, 2019

Conversation

erikNeville
Copy link
Contributor

In components/layout/SignedInLinks.js & SignedOutLinks I changed Log In and Log Out to Sign In and Sign Out.

@coultergeist
Copy link
Contributor

Erik, thanks for making those changing to the Nav. Need one more review and then can be merged. Everything looks good and functional tests pass.

Copy link
Contributor

@hkhual hkhual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on local machine, everything work fine. can merge.

Copy link
Contributor

@coultergeist coultergeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erik, thanks for making those changing to the Nav. Need one more review and then can be merged. Everything looks good and functional tests pass.

@coultergeist coultergeist merged commit 516da7f into dev Mar 5, 2019
@coultergeist
Copy link
Contributor

No merge conflicts present. Code functions correctly. Changes implemented. PR merged and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants