Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Store] Fix: Add func send task capture [weak self] #62

Merged

Conversation

yochidros
Copy link
Contributor

@yochidros yochidros commented Jun 15, 2022

This PR, Fix tests ActomatonStore.deinitTests to pass from failure.

スクリーンショット 2022-06-15 9 51 56

it's ActomatonStore fixed to add weak self capture because to when do deinit then not deallocation Store instance.

@yochidros yochidros marked this pull request as ready for review June 15, 2022 01:21
@inamiy inamiy added the bug Something isn't working label Jun 15, 2022
@inamiy inamiy added this to the 0.6.1 milestone Jun 15, 2022
@inamiy inamiy self-requested a review June 15, 2022 01:31
Comment on lines +101 to +102
return Task(priority: priority) { [weak self] in
let task = await self?.actomaton.send(.action(action), priority: priority, tracksFeedbacks: tracksFeedbacks)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@inamiy inamiy merged commit d4a2d3b into Actomaton:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants