Adds guard clause to prevent recovery of non-deleted records #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all records respond to the `.recover` method, including records that are not deleted. This change ensures that calling `recover` on un-deleted records will no-op. We also added specs to verify this behavior. Co-authored-by: Valerie Woolard <valerie.woolard@gmail.com>
mvz
approved these changes
Oct 22, 2019
|
Thanks, @marycodes2! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all records respond to the
.recovermethod, includingrecords that are not deleted. This change ensures that calling
recoveron un-deleted records will no-op. We also added specs to verify this
behavior.
Co-authored-by: Valerie Woolard valerie.woolard@gmail.com