Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a record being dirty after destroying it #135

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Oct 22, 2019

Part of #108, fixing the following issue:

A record is dirty after being destroyed. and Rails therefore considers that there are still changes to be saved to the database. Thus, if an after_destroy callback modifies the deleted record again, this may trigger new unwanted callbacks. Moreover, this prevents a record to be recovered after being destroyed without reloading it.

…destroy_fully!

Fix a record being dirty after destroying it.
@mvz mvz merged commit 22f1244 into master Oct 22, 2019
@mvz mvz deleted the not-dirty-after-destroy branch October 22, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants