Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle with_deleted association option as a scope #147

Merged
merged 3 commits into from
Jan 31, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 31, 2020

Fixes #76.

By injecting the proper scope in the association, Rails handles creating all queries automatically.

@mvz mvz merged commit 6809f91 into master Jan 31, 2020
@mvz mvz deleted the issue-76-join-with-deleted branch January 31, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with_deleted on joins does not unscope
1 participant