Replace destroy! with destroy_fully! on relations
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
issue-82-remove-destroy-bang-on-associations
branch
from
bdc999a
to
9303ded
Compare
|
|
On single records, destroy! was already replaced with destroy_fully! before. This change does the same for relations. This reduces surprising behavior when compared to standard ActiveRecord.
mvz
force-pushed
the
issue-82-remove-destroy-bang-on-associations
branch
from
9303ded
to
7d37aa6
Compare
mvz
force-pushed
the
issue-82-remove-destroy-bang-on-associations
branch
from
7d37aa6
to
43b2f40
Compare
mvz
force-pushed
the
issue-82-remove-destroy-bang-on-associations
branch
from
43b2f40
to
030fb68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On single records,
destroy!was already replaced withdestroy_fully!before. This change does the same for relations. This reduces surprising behavior when compared to standard ActiveRecord.destroy!is kept for now with a deprecation message.See #82.