Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Ruby 3.1 in CI #268

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Test with Ruby 3.1 in CI #268

merged 1 commit into from
Jan 7, 2022

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Dec 26, 2021

No description provided.

@cloudsbird
Copy link
Contributor

Hi Bro I see you want to test the app with Ruby 3.1

but some people have test the rails first with 3.1 and leads to some error.
Because we depends on Rails 7 (active_record 7.0) better we wait until they fix this error.
Before we test in Ruby 3.1

here is my reference
https://gist.github.com/claudiug/bdc2fb70b10d19513208c816588aed92

@mvz
Copy link
Contributor Author

mvz commented Dec 28, 2021

Thanks @cloudsbird, I've seen that error in the tests for another gem I maintain: https://github.com/mvz/non-digest-assets/runs/4639998453?check_suite_focus=true#step:6:18. It's good to know that's a problem others are seeing too.

In acts as paranoid, the error is different: https://github.com/ActsAsParanoid/acts_as_paranoid/runs/4639915973?check_suite_focus=true#step:8:8.

I haven't looked into this error yet. In any case, this PR won't get merged until it's green.

@mvz mvz merged commit c86b5be into master Jan 7, 2022
@mvz mvz deleted the test-with-ruby-3-1 branch January 7, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants