Add validator #683
Merged
Add validator #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's still a WIP, it's missing some things: * More tests * Check if tests cover all the branching * Review error messages * Better type intersection * Even more tests, but done with quickcheck or similar
rkuhn
reviewed
Mar 6, 2024
The test in question was a subset of another test
Kelerchian
reviewed
Mar 14, 2024
rkuhn
reviewed
Mar 18, 2024
| let cbor = Cow::Owned(cbor); | ||
| if let Some(value) = value.get(&cbor) { | ||
| if let e @ Err(_) = validate(&value.decode(), ty) { | ||
| return e; |
There was a problem hiding this comment.
One thing I just realise:
- if these errors are to be read by humans, they would be vastly more useful if they carried the context (i.e. the path inside the event payload object)
- since these errors will usually not be read by humans and they are expensive to construct (string formatting), it would be really great if the error carried the information for printing but only did it in its
Displayimpl
These two should probably be done in separate add-on PRs once this is merged.
rkuhn
reviewed
Mar 19, 2024
rkuhn
approved these changes
Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.