Skip to content

Commit

Permalink
#12 Removing Sakura Bushes.
Browse files Browse the repository at this point in the history
  • Loading branch information
@Ad5001
Ad5001 committed May 11, 2017
1 parent 8311298 commit 34cd479
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/Ad5001/BetterGen/structure/SakuraTree.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,8 @@ class SakuraTree extends Tree {
*/
public function __construct() {
$this->trunkBlock = Block::LOG;
$this->leafBlock = Block::WOOL;
$this->leafBlock = Block::AIR; // To remove bushes
$this->realLeafBlock = Block::WOOL;
$this->leafType = 6;
$this->leaf2Type = 0;
$this->type = Wood::OAK;
Expand Down Expand Up @@ -668,7 +669,7 @@ public function setLeave(ChunkManager $level, $x, $y, $z, Random $random) {
$this->leafType,
$this->leaf2Type
] [( int ) $random->nextBoolean ()];
$level->setBlockIdAt($x, $y, $z, $this->leafBlock);
$level->setBlockIdAt($x, $y, $z, $this->realLeafBlock);

This comment has been minimized.

Sign in to view

Copy link
@inxomnyaa

inxomnyaa May 12, 2017

Collaborator

uh why

This comment has been minimized.

Sign in to view

Copy link
@inxomnyaa

inxomnyaa May 12, 2017 •
edited
Loading

Collaborator

please undo this one, this heavily conflicts with my fixed fork

also its just wrong, it doesn't fix the issue, its a stupid workaround

This comment has been minimized.

Sign in to view

Copy link
@Ad5001

Ad5001 May 12, 2017

Author Owner

Basicly, the bushes generator use the leafBlock from the Tree class.

This comment has been minimized.

Sign in to view

Copy link
@inxomnyaa

inxomnyaa May 12, 2017

Collaborator

wtf

This comment has been minimized.

Sign in to view

Copy link
@AvgZing

AvgZing May 12, 2017

what?!
$level->setBlockDataAt($x, $y, $z, $data);
}
}

5 comments on commit 34cd479

@Thunder33345
Copy link

@Thunder33345 Thunder33345 commented on 34cd479 May 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

day one: Added a ton of amazing features
day 10: removed feature # 2 because it causes a bug
day 12: removed feature # 4 # 8 because it conflict with feature # 7
day 15: removed feature # 7 because it's bugged out anyways

I have a feeling this will be how we go from now on...

@Thunder33345
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great apparently you cant escape them...

@AvgZing
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like it...

@Ad5001
Copy link
Owner Author

@Ad5001 Ad5001 commented on 34cd479 May 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it wasn't a bug. It just looked wierd. But now I will be starting readding features.

@AvgZing
Copy link

@AvgZing AvgZing commented on 34cd479 May 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But ow I will

XD but ow

Please sign in to comment.