Create PR, fixing tons of bugs #18
Conversation
TODO: Add the inner decorations/pillars TODO: Fix second floor entrance
|
Done, can be merged. |
| @@ -91,7 +92,7 @@ public function generateCave($x, $y, $z, Random $random) { | |||
| foreach($gen = $this->generateBranch($x, $y, $z, 5, 3, 5, $random ) as $v3 ) { | |||
| $generatedBranches --; | |||
| if ($generatedBranches <= 0) { | |||
| $gen->send(self::STOP); | |||
| $gen->send(self::STOP); // send not found.. @Ad5001 what is that | |||
There was a problem hiding this comment.
@thebigsmileXD @jasonwynn10 http://php.net/manual/en/generator.send.php
It was my first generator.
There was a problem hiding this comment.
the function is missing and leads into alot of issues
There was a problem hiding this comment.
It's not missing, the generateBranch function is a generator (usage of yield keyword). All functions related to Generators can be found on PHP.net
There was a problem hiding this comment.
i looked into the yield. but stop/start are missing still.. could it be they are not supported by php7?
| break; | ||
| }elseif($b !== Block::AIR){ |
There was a problem hiding this comment.
You don't want to replace transparent blocks ;) (glass, water, pressure plates, doors...)
| $fallenTree = new FallenTree(new $tree()); | ||
| $fallenTree = new \Ad5001\BetterGen\structure\FallenTree( | ||
| new $tree() | ||
| ); |
There was a problem hiding this comment.
1st: a class error. Second: because the whole formatting was messed up anyways. Here it actually was a "debug" to get the correct error line (Cannot use tree as tree because already...), but fixed though
| @mkdir($this->getDataFolder()); | ||
| if(! file_exists(LootTable::getPluginFolder(). "processingLoots.json")) | ||
| file_put_contents(LootTable::getPluginFolder(). "processingLoots.json", "{}"); | ||
|
|
|
To explain this formating, I like 1 time opened the project with eclipse which decided to format it all ! |
|
|
||
|
|
||
| //TODO CHECK WHAT THIS IS SUPPOSED TO BE | ||
| $numForward = ($totalLength % 2 == 0) ? $totalLength - 1 : $totalLength; |
There was a problem hiding this comment.
this is not merge ready unless this is known
There was a problem hiding this comment.
This is known. This is the length of the leaves falling forward.
There was a problem hiding this comment.
idk why i left this in, i already fixed it
You don't format with eclipse. Rule no 1 of coding xd |
|
Never format with eclipse. Rookie mistake |
|
I did not choose. It's been done automaticly. That's the reason I deleted it. |
WIP, do not merge yet