Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuard Notification Separator/Dot Size Issue on Samsung #1826

Closed
ghost opened this issue Apr 15, 2018 · 9 comments
Closed

AdGuard Notification Separator/Dot Size Issue on Samsung #1826

ghost opened this issue Apr 15, 2018 · 9 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Apr 15, 2018

AdGuard's separator used in the notification seems to have a sizing issue on this Samsung device as the dot is much bigger than usual.

Seen on previous Nokia 6

37931402-38d042bc-3191-11e8-881a-5a2c7f8909d2

Seen on Samsung Galaxy J7 Pro

screenshot_20180415-164131

Your environment

  • Adguard version: 2.11.80 Beta
  • Adguard filtering mode: VPN
  • Device model: Samsung Galaxy J7 Pro
  • Operating system and version: Android 7.0
@Revertron
Copy link

It's not a separator that has an issue, it's a font used in notification on Samsung device.

@ghost
Copy link
Author

ghost commented Apr 15, 2018

It's not a separator that has an issue, it's a font used in notification on Samsung device.

Is there any potential workaround that AdGuard could do to circumvent this?

@Revertron
Copy link

Revertron commented Apr 15, 2018

Is there any potential workaround that AdGuard could do to circumvent this?

Just one - use another symbol. Just because of one of the worst device vendors :-/

@ameshkov
Copy link
Member

ameshkov commented Apr 15, 2018

— maybe?

@ameshkov ameshkov added this to the 2.12 milestone Apr 15, 2018
@ameshkov ameshkov self-assigned this Apr 15, 2018
@ameshkov
Copy link
Member

I'll see to it as I am on Samsung as well.

@ameshkov
Copy link
Member

Resolved in adguard-android/pull-requests/398

@ghost
Copy link
Author

ghost commented May 11, 2018

Perfect, thank you. 👍

screenshot_20180511-120604

There are three other places where the same separator issue occurs, and that's when tapping on any dot in 'Apps and Statistics', in 'App Details' and in 'Battery Details' (where line graphs are used). Doesn't look too bad in this scenario but it might be worth also making the same changes done previously for the sake of consistency?

screenshot_20180511-120553

@ameshkov
Copy link
Member

but it might be worth also making the same changes done previously for the sake of consistency?

The fix is too ugly and frankly, I'd better avoid replicating it elsewhere :)

@ghost
Copy link
Author

ghost commented May 15, 2018

That's completely understandable, thanks for the notification fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants