Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom hosts files support to the DNS filtering module #1851

Closed
ameshkov opened this issue May 3, 2018 · 6 comments
Closed

Add custom hosts files support to the DNS filtering module #1851

ameshkov opened this issue May 3, 2018 · 6 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

ameshkov commented May 3, 2018

Generally, it should work just like it works in the iOS version.

  1. Users should be able to add custom hosts files or adblock subscriptions.
  2. Custom DNS filtering rules need to be separated from the user filter.
  3. We may provide a list with some popular subscriptions to choose from.

Some ideas for the list:

@LewisLebentz
Copy link

So it's not currently possibly to add any other lists that block DNS requests?

I thought it would be possible as the iOS app can do it, and all the competitors like Blokada etc.?

@ameshkov
Copy link
Member Author

So it's not currently possibly to add any other lists that block DNS requests?

The only way would be to import them to the user filter.

@TPS
Copy link
Contributor

TPS commented Nov 19, 2018

Just to clarify, when 1 adds a custom filter(list), those filters aren't used for DNS-blocking (like the user filter(list) can be) if that's enabled⁉️

@ameshkov
Copy link
Member Author

@admitrevskiy

If DNS filtering is enabled, but no custom DNS upstream is selected, we should honor user's DNS Privacy settings: https://developer.android.com/about/versions/pie/android-9.0-changes-28#dns-privacy

@ameshkov
Copy link
Member Author

Issues with the current build:

  1. "Filters" item must be disabled when "DNS requests blocking" is unchecked
  2. "Filters" --> "DNS Filters"
  3. Subtext: 6 filters enabled or No filters enabled

@admitrevskiy
Copy link

Done.

Testing instructions for QA:
-Please, check this issue after #2800 #2803 and #2798 will be resolved
-Reinstall AG
-Examine new screens for DNS Filters (Settings –> DNS Filtering)
-Try to add and remove custom DNS Filters (with regular and host filtering rules)
-Try to add invalid filter (insert wrong url into Add new filter dialog)
-Examine DNS filtering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants