Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not notify users with an active subscription that the license key is soon to expire #2105

Closed
ameshkov opened this issue Sep 5, 2018 · 1 comment
Closed

Do not notify users with an active subscription that the license key is soon to expire #2105

ameshkov opened this issue Sep 5, 2018 · 1 comment
Assignees
@ameshkov
Labels
Enhancement P2: High
Milestone
2.12

Comments

@ameshkov
Copy link
Member

ameshkov commented Sep 5, 2018

It does not make much sense to show a notification if the subscription is active and will be renewed automatically.
@ameshkov ameshkov added this to the 2.12 milestone Sep 5, 2018
@ameshkov ameshkov self-assigned this Sep 5, 2018
@ameshkov
Copy link
Member Author

ameshkov commented Sep 5, 2018

Resolved in adguard-android/pull-requests/697

How to test

  1. Obtain (or generate) a license key with an active subscription which expires TODAY.
  2. Active AdGuard
  3. Click "Refresh license status" on the "license status" screen

On the stable (2.11) version, you'll see a notification that the license is soon to expire.
On the new 2.12, there will be no such notification.

@zebrum zebrum closed this as completed Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ameshkov ameshkov

Labels
Enhancement P2: High
Projects
None yet
Milestone
2.12
Development

No branches or pull requests
2 participants
@ameshkov @zebrum