Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in the Apps Management settings #2308

Closed
ameshkov opened this issue Nov 14, 2018 · 34 comments
Closed

Crash in the Apps Management settings #2308

ameshkov opened this issue Nov 14, 2018 · 34 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

Details:
https://sentry.adguard.com/adg/adguard-android-rs/issues/13243/

@infinitewaveparticle
Copy link

This has been an issue for me for the entire time I've had AdGuard. For me to successfully be able to open the App Management tab I have to first disconnect from the internet AND disable AdGuard. This is very annoying.

@ameshkov
Copy link
Member Author

@infinitewaveparticle this must be something else as this crash is a new thing introduced (and already fixed) in the nightly builds.

Could you please enable crash reporting in AdGuard service, reproduce the crash and comment on this issue immediately after that (so that I could figure that the crash report is from you?)

@TPS
Copy link
Contributor

TPS commented Nov 19, 2018

I just sent mine, as it's still doing this. I thought y'all hadn't gotten to this yet. 🤷‍♂️

@Revertron
Copy link

Fixed already in nightlies.

@TPS
Copy link
Contributor

TPS commented Nov 28, 2018

Yes, thanks very much 🙇 @Revertron (pass that along to all whomever fixed it 😉)!

@sophisticated-zero
Copy link

@Revertron we received a message from a customer who claims that the issue persists even with latest update 3.0.180
User's ID – 2293655

@ameshkov
Copy link
Member Author

@Yevhen1996 please ask him to enable crash reporting in the settings, we will check & fix the most often crashes anyways.

@infinitewaveparticle
Copy link

@ameshkov My apologies for not responding sooner. I just now enabled crash reporting and reproduced the crash. I must note, however, that just before I updated to yesterday's release I hadn't noticed it happening. I don't often use the Apps Management because I rarely need to enable or disable an app from my current settings. I also have only noticed the crash when using WiFi; I don't ever recall it crashing while using cellular data. It always works while not connected, though, and especially after also disabling AdGuard.

@infinitewaveparticle
Copy link

Please note that the crash happened approximately 5-10 minutes prior to submitting the comment above.

@ameshkov
Copy link
Member Author

@infinitewaveparticle got it, thank you!

@ameshkov
Copy link
Member Author

@infinitewaveparticle could you please do just one more thing?

Next time the issue happens:

  1. Go to settings -> advanced -> export logs and system info
  2. Send the file to devteam@adguard.com (and mention this issue in the email)

@infinitewaveparticle
Copy link

@ameshkov I experimented a bit more... turns out that it crashes now no matter which data connection I'm using (Wi-Fi or cellular). It also happens when I'm disconnected from the internet. I now have to disable AdGuard to even be able to open Apps Management. This wasn't happening prior to the most recent release, but it did happen prior to the release before it. So whatever was changed from the version prior to the latest is headed in the wrong direction.

@infinitewaveparticle
Copy link

infinitewaveparticle commented Jan 31, 2019

By the way, my device is a Samsung Galaxy S7 Edge running stock Android 8. I don't like having to purposely crash it while being connected to the internet because everything I stop from connecting is then free to connect. I block all but a few user apps and I block all Google & Samsung connections via DNS.

@ameshkov
Copy link
Member Author

ameshkov commented Feb 1, 2019

@infinitewaveparticle the logs will help a lot, it's not a common issue.

@zzebrum
Copy link
Contributor

zzebrum commented Feb 8, 2019

@infinitewaveparticle hello! any new about reproducing the problem?

@infinitewaveparticle
Copy link

@ameshkov @zzebrum Seemingly out of the blue I can no longer reproduce the crash. I didn't change anything. Smh...

@infinitewaveparticle
Copy link

Which is a good thing... I'll let you know if anything changes.

@TheHasagi
Copy link
Contributor

Another case : 1969826

@safaksama2018
Copy link

safaksama2018 commented Mar 1, 2019

İ just sent latest extended logs to devteam@adguard.com mine doesn't matter with Wi-Fi on or off cellular on or off or adguard on or off this is Samsung android 8 mobile all detail inside the logs. if reproduce crash need i could that easy because it's every time crash when ever try to open app management screen only %1-2 time succeed without crash to open those settings just normal. I think maybe it could be because I got allot off apps so could you please extend buffer some maybe it could fix that way.

@safaksama2018
Copy link

Notice i use dual sim card plus wi-fi any news about fix?

@Revertron
Copy link

You have this kind of crash, apparently:

ERROR com.adguard.android.b.h - Thread: Thread[cached-pool-1-thread-433,5,main]; Uncaught exception:

android.database.sqlite.SQLiteCantOpenDatabaseException: unable to open database file (code 2062)
#################################################################
Error Code : 2062 (SQLITE_CANTOPEN_EMFILE)
Caused By : Application has opened too many files. Maximum of available file descriptors in one process is 1024 in default.
	(unable to open database file (code 2062))
#################################################################
	at android.database.sqlite.SQLiteConnection.nativeExecuteForCursorWindow(Native Method) ~[na:0.0]
	at android.database.sqlite.SQLiteConnection.executeForCursorWindow(SQLiteConnection.java:1018) ~[na:0.0]
	at android.database.sqlite.SQLiteSession.executeForCursorWindow(SQLiteSession.java:836) ~[na:0.0]
	at android.database.sqlite.SQLiteQuery.fillWindow(SQLiteQuery.java:62) ~[na:0.0]
	at android.database.sqlite.SQLiteCursor.fillWindow(SQLiteCursor.java:152) ~[na:0.0]
	at android.database.sqlite.SQLiteCursor.getCount(SQLiteCursor.java:141) ~[na:0.0]
	at android.database.AbstractCursor.moveToPosition(AbstractCursor.java:219) ~[na:0.0]
	at android.database.AbstractCursor.moveToNext(AbstractCursor.java:268) ~[na:0.0]
	at com.adguard.android.db.b.a(AppRulesDaoImpl.java:58) ~[na:0.0]
	at com.adguard.android.service.g.a(AppRulesServiceImpl.java:206) ~[na:0.0]
	at com.adguard.android.service.g.a(AppRulesServiceImpl.java:152) ~[na:0.0]
	at com.adguard.android.service.g.a(AppRulesServiceImpl.java:132) ~[na:0.0]
	at com.adguard.android.ui.AppsManagementMainActivity.a(AppsManagementMainActivity.java:2440) ~[na:0.0]
	at com.adguard.android.ui.AppsManagementMainActivity.a(AppsManagementMainActivity.java:83) ~[na:0.0]
	at com.adguard.android.ui.AppsManagementMainActivity$4.run(AppsManagementMainActivity.java:635) ~[na:0.0]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) ~[na:0.0]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) ~[na:0.0]
	at java.lang.Thread.run(Thread.java:764) ~[na:0.0]

@Revertron
Copy link

@safaksama2018 Please, try this build with the fix:
https://uploads.adguard.com/adguard-v3.0.266n-issue2308.apk
You can install it over whatever version you have on your device now.

@safaksama2018
Copy link

safaksama2018 commented Mar 6, 2019 via email

@ameshkov
Copy link
Member Author

ameshkov commented Mar 6, 2019

@safaksama2018 could you please send the logs again to devteam? We'll check what's the difference

@ameshkov
Copy link
Member Author

ameshkov commented Mar 6, 2019

I mean to devteam@adguard.com

@safaksama2018
Copy link

Here is the latest nightly build logs. It will delete in 7 day I sent there because I can't attach log files directly here.

https://we.tl/t-OYiP0xen7Y

@safaksama2018
Copy link

safaksama2018 commented Mar 6, 2019 via email

@ameshkov
Copy link
Member Author

ameshkov commented Mar 9, 2019

@safaksama2018 hm, I checked the logs, but I don't see any crash info there. Is it still happening on the latest nightly?

@safaksama2018
Copy link

safaksama2018 commented Mar 10, 2019 via email

@ameshkov
Copy link
Member Author

That's weird, I see no new crash reports. Do you have them enabled?

One more thing -- maybe it crashes differently now, and that's why I cannot see anything.

Could you please export logcat for us? Here's how to do it:
https://kb.adguard.com/en/android/solving-problems/logcat

@safaksama2018
Copy link

safaksama2018 commented Mar 12, 2019 via email

@ameshkov
Copy link
Member Author

Got it, thank you.

Stack trace:

03-12 14:13:30.461 17719 17778 E AndroidRuntime: FATAL EXCEPTION: cached-pool-1-thread-4
03-12 14:13:30.461 17719 17778 E AndroidRuntime: Process: com.adguard.android, PID: 17719
03-12 14:13:30.461 17719 17778 E AndroidRuntime: android.database.CursorWindowAllocationException: Cursor window allocation of 2048 kb failed. 
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at android.database.CursorWindow.<init>(CursorWindow.java:108)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at android.database.AbstractWindowedCursor.clearOrCreateWindow(AbstractWindowedCursor.java:198)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at android.database.sqlite.SQLiteCursor.clearOrCreateWindow(SQLiteCursor.java:309)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at android.database.sqlite.SQLiteCursor.fillWindow(SQLiteCursor.java:147)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at android.database.sqlite.SQLiteCursor.getCount(SQLiteCursor.java:141)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at android.database.AbstractCursor.moveToPosition(AbstractCursor.java:219)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at android.database.AbstractCursor.moveToNext(AbstractCursor.java:268)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at com.adguard.android.db.b.a(AppRulesDaoImpl.java:58)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at com.adguard.android.service.g.a(AppRulesServiceImpl.java:206)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at com.adguard.android.service.g.a(AppRulesServiceImpl.java:152)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at com.adguard.android.service.g.a(AppRulesServiceImpl.java:132)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at com.adguard.android.ui.AppsManagementMainActivity.a(AppsManagementMainActivity.java:2440)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at com.adguard.android.ui.AppsManagementMainActivity.a(AppsManagementMainActivity.java:83)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at com.adguard.android.ui.AppsManagementMainActivity$4.run(AppsManagementMainActivity.java:635)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
03-12 14:13:30.461 17719 17778 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:764)

@ameshkov ameshkov modified the milestones: 3.0, 3.1 Mar 14, 2019
@ameshkov
Copy link
Member Author

@safaksama2018 as I see this is not the latest build, and maybe the fix was not included there. Could you please update AG to the latest nightly ver?

@safaksama2018
Copy link

Latest nightly still have that bad bug its not fixed yet but i read, on the development logs its show rollback hope it could fix as soon i still waiting for that it's impossible to configure each apps at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants