Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS shouldn't be in apps management search result #2505

Closed
aspasskaya opened this issue Jan 31, 2019 · 2 comments
Closed

DNS shouldn't be in apps management search result #2505

aspasskaya opened this issue Jan 31, 2019 · 2 comments
Assignees
Milestone

Comments

@aspasskaya
Copy link
Contributor

aspasskaya commented Jan 31, 2019

!Also, "Android OS" cannot be found in the "Apps Management" section.

image

image

image

@aspasskaya aspasskaya added the Bug label Jan 31, 2019
@aspasskaya aspasskaya added this to the 3.0 milestone Jan 31, 2019
@aspasskaya aspasskaya changed the title DNS shouldn't be counted in total traffic in apps management DNS shouldn't be in apps management search result Jan 31, 2019
@Nzzyme
Copy link

Nzzyme commented Feb 7, 2019

I searched with "android os" and see the correct app "Android OS" in the results.
Searched with "adguard" and see three results "DNS", "Android OS" and "AdGuard" (which needs to be fixed).
Searched with "dns" and see the correct entry "DNS" in the search results.

I think the title of this issue is slightly misleading. The entry "DNS" should be available in Apps Management but what I think the user @aspasskaya is referring to is that "DNS" should not be shown in the search results when we do a search with the keyword "adguard" (or in his case "android os").

Another thing what I noticed was that when I did a search with the keyword "app", I am seeing so many search results of apps that do not have the three characters "app" in their name. It is perhaps showing the apps whose package name has the keyword "app" (that is AG is not just searching the app's common name as seen below the icon but also searches for the package name). is this how it was designed to search?

Test version used for above: AG 3.0.229 (Nightly).

@ameshkov
Copy link
Member

ameshkov commented Feb 7, 2019

DNS is shown because it's package name is "com.adguard.dns" (that's the name we chose as this is not a real package). This would be quite problematic to change this now:(

@zzebrum zzebrum closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants