Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 28 DNS Privacy settings #2797

Closed
admitrevskiy opened this issue Jun 14, 2019 · 3 comments
Closed

API 28 DNS Privacy settings #2797

admitrevskiy opened this issue Jun 14, 2019 · 3 comments

Comments

@admitrevskiy
Copy link

#1851 (comment)

https://developer.android.com/about/versions/pie/android-9.0-changes-28#dns-privacy

@admitrevskiy admitrevskiy added this to the 3.2 milestone Jun 14, 2019
@admitrevskiy admitrevskiy self-assigned this Jun 14, 2019
@ameshkov ameshkov modified the milestones: 3.2, 3.3 Jun 17, 2019
@admitrevskiy
Copy link
Author

Done (v3.3)

Testing instructions for QA:

  • Reinstall AG on device with Android P+
  • Enable DNS filtering and select regular server
  • Enable Private DNS in Auto mode
  • Start protection

Expected result:

  • You will see notification
  • Tap in Disable Private DNS should lead you to Android Wireless Network settings
  • Tap on Change server should lead you to Select DNS server screen
  • Notification will be visible until you change server to encrypted or disable Private DNS
  • Enable DNS filtering and select any server
  • Enable Private DNS in Provider mode
  • Start protection

Expected result:

  • You will see notification You are using Private DNS and connected to <server_name>
  • Tap in Disable Private DNS should lead you to Android Wireless Network settings
  • Notification will be visible until you disable Private DNS

@ameshkov
Copy link
Member

ameshkov commented Jul 25, 2019

Two issues with the current implementation:

  1. AdGuard DNS in the notification text is misleading, replace it with DNS filtering.
  2. Change the notification text. Instead of Please disable Private DNS it should be: If you want DNS filtering to work properly, please disable Private DNS in Android settings.
  3. Tap on the notification should lead to DNS filtering settings.
  4. We might need to limit this function to Android Q only because on Pie Private DNS can not work alongside a VPN at all

@admitrevskiy
Copy link
Author

Done.

@zzebrum zzebrum closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants